[V3 reports] Display user discrim #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 1, 2018 15:16
minor change for clarity
Kowlin
reviewed
Jul 8, 2018
| @@ -175,7 +175,10 @@ def pred(m): | |||
| if await self.bot.embed_requested(channel, author): | |||
| em = discord.Embed(description=report) | |||
| em.set_author( | |||
| name=_("Report from {0.display_name}").format(author), icon_url=author.avatar_url | |||
| name=_("Report from {author}{maybe_nick}").format( | |||
There was a problem hiding this comment.
A bit of a questionable formatting job here?
If I'm reading this code correctly this would make a username appear as the following:
KowlinNickname
There was a problem hiding this comment.
Wiith how maybe_nick is passed to that, you'll either just get:
Username#discrimantor if no nickname, or Username#discriminator (Nickname) if they have one (making it more clear on nicknames, since those are more likely to change)
There was a problem hiding this comment.
Ah right, this relied on me thinking that the author object would only return the username and not the full user-discrim.
Kowlin
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
This ensures less chance of accidentally mixing up users, still showing the nickname as well if there is one