Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodules #2019

Closed
wants to merge 1 commit into from
Closed

Update submodules #2019

wants to merge 1 commit into from

Conversation

Proximyst
Copy link

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Instead of cloning empty submodules, it should now automatically pull all of the modules as it is from remote. This allows for repositories to be their own cogs and rather use submodules in an "indexing" repository, as we do with https://github.com/r-Norge/tannhjul

@Tobotimus Tobotimus added Type: Enhancement Something meant to enhance existing Red features. V2 Status: Frozen We might make plans for this later. labels Aug 16, 2018
@Tobotimus
Copy link
Member

Hi, thanks for your PR.

Unfortunately I'm gonna freeze this as V2 is at a very low priority (technically it's bugfix-only). It will probably be closed if it doesn't get any attention over the next few months.

@mikeshardmind
Copy link
Contributor

I'll just toss on a note, that if you want this behavior in V3's downloader, you may want to add a note on #1968

@Proximyst
Copy link
Author

@Tobotimus The PR is mostly to help out people using such, as us over at r/Norge wish to use it for the bot we call Askeladden (A Norwegian folk tale icon), and we wish to have the repositories in an easy way to handle with proper permissions. Seeing as the server is relatively small at little over 3k users, there is without a doubt others who most likely also would like to see this be added for their own organisational usecases and simply for the fact that it's simple to handle.

@mikeshardmind I will be sure to do so in a moment, thank you!

@mikeshardmind
Copy link
Contributor

Right now, V3's downloader updates submodules. As this is a behavior change, and not a critical fix or a non-code change, We're not going to include this for V2's EOL support, but if there's anything else with this you need for V3, feel free to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Frozen We might make plans for this later. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants