[Downloader] More robust repo loading #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when downloader was loaded, the RepoManager would spawn a task to load available repos. If one repo failed loading for some reason, the function would raise and the remaining repos would never be loaded, however downloader would still appear to load correctly. This change handles exceptions better during repo loading, but also, if an unhandled exception is raised, downloader will fail to load as it should. Also included, as requested in Cog-Creators#1968, is the --recurse-submodules flag in cloning/pulling repositories. This change resolves Cog-Creators#1950. Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
mikeshardmind
approved these changes
Sep 22, 2018
There was a problem hiding this comment.
This appears to be fine, and appears to achieve the goals it sets out for without breaking anything else in the process. Might be obsoleted in the work @calebj has been doing for reworking the downloader's internals later on, but it's worth fixing the issues with this now.
Tobotimus
added
QA: Passed
Tobotimus
added a commit
to Tobotimus/Red-DiscordBot
that referenced
this pull request
Sep 24, 2018
I somehow managed to botch this in Cog-Creators#2121 Signed-off-by: Toby Harradine <t.harradine@student.unsw.edu.au>
Tobotimus
added a commit
that referenced
this pull request
Sep 24, 2018
I somehow managed to botch this in #2121 Signed-off-by: Toby Harradine <t.harradine@student.unsw.edu.au>
Jackenmen
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when downloader was loaded, the RepoManager would spawn a task to load available repos. If one repo failed loading for some reason, the function would raise and the remaining repos would never be loaded, however downloader would still appear to load correctly.
This change handles exceptions better during repo loading, but also, if an unhandled exception is raised, downloader will fail to load as it should.
Also included, as requested in #1968, is the --recurse-submodules flag in cloning/pulling repositories.
This change resolves #1950.