Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] Hackban fixes #2128

Merged
merged 4 commits into from
Sep 24, 2018
Merged

[V3] Hackban fixes #2128

merged 4 commits into from
Sep 24, 2018

Conversation

mikeshardmind
Copy link
Contributor

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

If the member is in the guild, delegates to existing ban logic. (Fixes #2127)

Additionally, check that we have ban perms prior to attempting to fetch the existing ban list.

Michael Hall and others added 3 commits September 14, 2018 14:11
Would prefer being consistent with the use of this method, and also prevents warnings about unresolved attributes.
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@Tobotimus Tobotimus added QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). and removed QA: Needed labels Sep 24, 2018
@Tobotimus Tobotimus assigned Tobotimus and unassigned aikaterna Sep 24, 2018
@Tobotimus Tobotimus merged commit 404800c into Cog-Creators:V3/develop Sep 24, 2018
@mikeshardmind mikeshardmind deleted the iss2127 branch December 26, 2019 17:01
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V3] Ban peers with hackban
4 participants