Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3] json_io atomic write improvements. #2132

Merged
merged 1 commit into from
Sep 24, 2018
Merged

[V3] json_io atomic write improvements. #2132

merged 1 commit into from
Sep 24, 2018

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Sep 15, 2018 •
edited

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes a deprecation issue with lock usage.

Deprecated since version 3.7: Lock acquiring using await lock or yield from lock and with statement (with await lock, with (yield from lock)) are deprecated.

Forces a file fsync prior and a directory fsync (where available) after rename to prevent issues with left behind temp files.

@Kowlin Kowlin added V3 labels Sep 15, 2018
@mikeshardmind

This comment has been minimized.

Sign in to view
@Kowlin

This comment has been minimized.

Sign in to view
@mikeshardmind mikeshardmind changed the title [V3] lock fix [V3] json_io atomic write improvements. Sep 17, 2018
use fsync to avoid issues with disk cache
f412b7b 
Modifies function names and documentation:

This is not threadsafe. Comments were clarified.
@Tobotimus Tobotimus self-requested a review September 23, 2018 13:46
@Tobotimus Tobotimus merged commit 84ac5f3 into Cog-Creators:V3/develop Sep 24, 2018
@Tobotimus Tobotimus assigned Tobotimus and unassigned Redjumpman Sep 24, 2018
@Tobotimus Tobotimus added QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). and removed QA: Needed labels Sep 24, 2018
@mikeshardmind mikeshardmind deleted the lock-fix branch December 26, 2019 17:01
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobotimus Tobotimus Tobotimus approved these changes

@tekulvw tekulvw Awaiting requested review from tekulvw

Assignees

@Tobotimus Tobotimus

Labels
QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikeshardmind @Kowlin @Tobotimus @Jackenmen @Redjumpman