Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 RedBase] Add missing @staticmethod to send_filtered #2143

Merged
merged 2 commits into from
Sep 23, 2018
Merged

[V3 RedBase] Add missing @staticmethod to send_filtered #2143

merged 2 commits into from
Sep 23, 2018

Conversation

Zephyrkul
Copy link
Contributor

Type

  • Bugfix

Description of the changes

Title says it all.

@mikeshardmind
Copy link
Contributor

This was actually intended to be a static method and not even require self. >.<

@Zephyrkul
Copy link
Contributor Author

Oh, I'll change it to that, then

@Zephyrkul Zephyrkul changed the title [V3 RedBase] Add missing self to send_filtered [V3 RedBase] Add missing @staticmethod to send_filtered Sep 21, 2018
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this one @Zephyrkul

@Tobotimus Tobotimus added V3 QA: Bypassed QA is unnecessary. labels Sep 23, 2018
@Tobotimus Tobotimus merged commit a301b2c into Cog-Creators:V3/develop Sep 23, 2018
@Zephyrkul Zephyrkul deleted the patch-2 branch October 3, 2018 02:09
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Bypassed QA is unnecessary. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants