Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Trivia] Handle smart quotes #2162

Merged
merged 4 commits into from
Oct 5, 2018
Merged

[V3 Trivia] Handle smart quotes #2162

merged 4 commits into from
Oct 5, 2018

Conversation

mikeshardmind
Copy link
Contributor

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Adds a new filter function for substituting out smart-quotes.

Makes trivia use it.

@Twentysix26
Copy link
Member

My only nitpick here is that the name of the function looks pretty weird with un being separate and smartquote as a single word. As far as I know the un prefix is never used as a word on its own in English.
I would have went with something like normalize_smart_quotes (replace could work too), which also respects the other function names being plural instead of singular.
In this case the to_filter parameter name should also be renamed since you're not filtering, you are transforming text.

@Tobotimus Tobotimus added Type: Enhancement Something meant to enhance existing Red features. QA: Needed Type: Feature New feature or request. labels Oct 1, 2018
@Tobotimus Tobotimus added this to the RC 1 milestone Oct 2, 2018
@Tobotimus Tobotimus self-assigned this Oct 2, 2018
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR 👍

@Tobotimus Tobotimus merged commit 1393292 into Cog-Creators:V3/develop Oct 5, 2018
@mikeshardmind mikeshardmind deleted the smart-quote-kills branch December 26, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Something meant to enhance existing Red features. Type: Feature New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants