Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3] Unawaited command #2167

Merged
merged 1 commit into from
Oct 2, 2018
Merged

[V3] Unawaited command #2167

merged 1 commit into from
Oct 2, 2018

Conversation

bobloy
Copy link
Contributor

@bobloy bobloy commented Oct 1, 2018

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

load_extension is a coroutine and should be awaited

@bobloy bobloy requested a review from tekulvw as a code owner October 1, 2018 19:56
@Tobotimus Tobotimus added V3 QA: Bypassed QA is unnecessary. labels Oct 2, 2018
Tobotimus
Tobotimus approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Tobotimus Tobotimus merged commit d5899fa into Cog-Creators:V3/develop Oct 2, 2018
@bobloy bobloy deleted the V3/rpc_handler_fix branch October 2, 2018 12:04
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobotimus Tobotimus Tobotimus approved these changes

@tekulvw tekulvw Awaiting requested review from tekulvw

Assignees
No one assigned
Labels
QA: Bypassed QA is unnecessary. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobloy @Tobotimus @Jackenmen