Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3 Trivia] On / Off also resolve to bool with YAML #2177

Merged
merged 2 commits into from Oct 9, 2018
Merged

[V3 Trivia] On / Off also resolve to bool with YAML #2177

merged 2 commits into from Oct 9, 2018

Conversation

bobloy
Copy link
Contributor

@bobloy bobloy commented Oct 3, 2018

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

On and Off also resolve to boolean values in YAML and should be equally addressed.

For example, the answer to
Name this video game: https://www.youtube.com/watch?v=xajMfQuVnp4
is
Off

@bobloy bobloy requested a review from Tobotimus as a code owner October 3, 2018 18:50
@Twentysix26 Twentysix26 added Type: Enhancement Something meant to enhance existing Red features. V3 labels Oct 4, 2018
Tobotimus
Tobotimus approved these changes Oct 6, 2018
View reviewed changes
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. In the future I might think about modifying the YAML loader so it doesn't parse bools at all

@Tobotimus Tobotimus added the QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). label Oct 6, 2018
@Tobotimus Tobotimus changed the base branch from V3/develop to V3/release/3.0.0 October 9, 2018 11:04
@Tobotimus Tobotimus added this to the RC 2 milestone Oct 9, 2018
@Tobotimus Tobotimus merged commit f85034e into Cog-Creators:V3/release/3.0.0 Oct 9, 2018
@bobloy bobloy deleted the V3/trivia_bool_part2 branch October 9, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobotimus Tobotimus Tobotimus approved these changes

Assignees
No one assigned
Labels
QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.0.0rc2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobloy @Tobotimus @Twentysix26