Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3 Menus] ctx.me so this will work in DM's #2183

Merged
merged 2 commits into from
Oct 6, 2018
Merged

[V3 Menus] ctx.me so this will work in DM's #2183

merged 2 commits into from
Oct 6, 2018

Conversation

bobloy
Copy link
Contributor

@bobloy bobloy commented Oct 5, 2018

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

ctx.me handles using ctx.guild.me if ctx.guild is not None
ctx.guild.me directly error in DMs

@bobloy bobloy mentioned this pull request Oct 5, 2018
Closed
3 tasks
Tobotimus
Tobotimus approved these changes Oct 6, 2018
View reviewed changes
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😃

@Tobotimus Tobotimus added QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). and removed QA: Needed labels Oct 6, 2018
@Tobotimus Tobotimus added this to the RC 1 milestone Oct 6, 2018
@Tobotimus Tobotimus merged commit fdf3f86 into Cog-Creators:V3/develop Oct 6, 2018
@bobloy bobloy deleted the V3/menues-ctx branch October 8, 2018 12:25
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobotimus Tobotimus Tobotimus approved these changes

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

Assignees
No one assigned
Labels
QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bobloy @Tobotimus @Jackenmen @Redjumpman