Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Permissions] Fix ValueError for "default" rule in config/ACL #2200

Conversation

Tobotimus
Copy link
Member

Error was thrown when the "default" key existed and Permissions tried to iterate over the list mapping keys to int.

This was thrown when the "default" key existed and Permissions tried to iterate over the list mapping keys as ints.

Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
@Tobotimus Tobotimus added this to the RC 2 milestone Oct 7, 2018
There seems to be a caching issue in the JSON driver when saving ints as keys

Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Copy link
Member

@Kowlin Kowlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fixes work as intended.

@Tobotimus Tobotimus added QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). and removed QA: Unassigned labels Oct 9, 2018
@Tobotimus Tobotimus merged commit 9217275 into Cog-Creators:V3/release/3.0.0 Oct 9, 2018
@Tobotimus Tobotimus deleted the V3/bugfix/permissions_default branch October 9, 2018 04:20
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants