Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3 Mod] Mute/Unmute bugfixes #2230

Merged
merged 1 commit into from Oct 12, 2018
Merged

[V3 Mod] Mute/Unmute bugfixes #2230

merged 1 commit into from Oct 12, 2018

Conversation

Zephyrkul
Copy link
Contributor

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Bugfix-only version of #2179. Resolves #2076.

Changes present in this branch:

  • Helper methods mute_user and unmute_user now take GuildChannel instead of solely TextChannel.
  • The bot will not attempt to mute a member with the Administrator permission, as that permission bypasses channel overwrites anyway. The bot will still unmute members with the Administrator permission (see [V3] Unmute has odd behaviour on admins #2076).
  • Audit reasons are now specified for mass mutes / unmutes.
  • A few typos and missing keyword specifiers were corrected.
  • Streamlined some logic and used some already-existing functions.

mikeshardmind
mikeshardmind approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue, and gives clear user facing feedback when a mute will fail due to admin perms, 👍 from me.

@Tobotimus Tobotimus added V3 QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). labels Oct 12, 2018
@Tobotimus Tobotimus added this to the RC 2 milestone Oct 12, 2018
Tobotimus
Tobotimus approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zephyrkul, and thanks @mikeshardmind for reviewing

@Tobotimus Tobotimus merged commit 6022c0f into Cog-Creators:V3/release/3.0.0 Oct 12, 2018
@Tobotimus Tobotimus mentioned this pull request Oct 12, 2018
Closed
@Zephyrkul Zephyrkul deleted the V3/release/unmute-fix branch October 12, 2018 05:02
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobotimus Tobotimus Tobotimus approved these changes

@mikeshardmind mikeshardmind mikeshardmind approved these changes

@palmtree5 palmtree5 Awaiting requested review from palmtree5

Assignees

@mikeshardmind mikeshardmind

Labels
QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.0.0rc2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zephyrkul @Tobotimus @mikeshardmind @Jackenmen