[V3 Core] Handle webhooks gracefully in automod immunity #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobotimus
approved these changes
Dec 21, 2018
Tobotimus
added
QA: Passed
Jackenmen
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
resolves #2336
This fix is under the assumption that webhook messages do get parsed by events which would take mod actions. Webhook messages have a few quirks to them. (user object in guild for author for one)
This makes them immune to automated moderation actions, but not count as a mod or admin as they require significant permissions to set up, but are automated in nature themselves.