[General] Add toggle to `[p]serverinfo` that shows more details #2382

PredaaA · 2019-01-20T17:52:56Z

Type

Bugfix
Enhancement
New feature

Description of the changes

Using [p]serverinfo true shows more details about the guild, such as verification levels, AFK channel and timeout, number of custom emojis, special and/or Nitro boost features. This is untoggled by default.

- Added some more informations about the server. (Verification level, AFK channel and timeout, custom emojis and special features). - Added custom texts for Region (and Verification levels). - Added more details about members (Number of humans, bots, and all status). - Show special features only if the server has one. - Show "Verified" logo only if the server is verified. - And changed the footer by adding how many time the bot as join the server.

Zephyrkul · 2019-01-20T18:08:35Z

Just FYI, your PR is failing a style check (clicky).

mikeshardmind

Overall nice looking embed with more info. Would love to see some leveraging of the mobile status info in this at some point too. There are a few things which should be changed here before this gets merged.

redbot/cogs/general/general.py

Added exception on server command for the phrase "To leave a server, just type its number.".

Update core_commands.py

- Adding "lurkers" check, for the new feature that are on bot which allow users to join a server in read-only (Works only on verified servers for now) - Adding streaming status. - Adding mobile status with suggestion of Sinbad.

PredaaA · 2019-02-06T03:20:13Z

I know that not everyone likes my PR for this serverinfo command, and I really can understand that because it's totally different than the original command, but also some people like it so that's why I continue to trying to improve it.

Fixed all changes that Sinbad asked.
Adding "lurkers" check, for the new feature that are on Discord which allow users to join a server in read-only (Works only on verified servers for now, only beta)
Adding streaming status.
Adding mobile status that a suggestion from Sinbad.

Thanks to testing channel on Red Discord for all your help.
(I'm sorry for all commits you see above, it wasn't intended to show it here, really sorry for that)

Zephyrkul · 2019-02-06T03:46:56Z

If this PR ends up being rejected, I wouldn't mind seeing it in a 3rd party cog.

PredaaA · 2019-02-06T03:49:53Z

That's what I've already done. I've added it into a 3rd party cog in my repo, that replace the original command.

Tobotimus · 2019-02-20T23:39:41Z

The embed is more cluttered, but I think the information on it is still easy to find. I was initially thinking of making it an option / add a "verbosity" argument to serverinfo, but I don't think that's necessary. So purely from a black box perspective I'd give this my 👍

Kowlin · 2019-02-22T05:17:39Z

I feel like this would be an appropriate candidate for a -verbose flag.

mikeshardmind · 2019-03-01T22:51:46Z

The detection of lurkers there is a bug to be fixed in discord (see: discord/discord-api-docs#855) , we shouldn't include something which exposes them in the mean time.

I also agree with kowlin about the verbosity setting, and it does not have to significantly change the logic to use this, just place certain parts under and if verbose: statement.

I've added a bool that are False by default and sent the original serverinfo command, and if set to True send my edited version. And I've disabled the lurkers detection until this bug (discord/discord-api-docs#855) isn't fixed.

PredaaA · 2019-03-02T01:15:28Z

I've added a bool that are False by default and sent the original serverinfo command, and if set to True send my edited version, and finally I think it's better with that, if users want more information about the server it just need to set True when send the command.
I've just keep the personalized text for region in original one, in my opinion it looks better like this, but maybe I'm wrong, tell me if you think it's better without.

And I've disabled the lurkers detection until the bug @mikeshardmind mentionned isn't fixed.

redbot/cogs/general/general.py

Jackenmen

Looks good to me, thanks for the PR!

PredaaA requested a review from palmtree5 as a code owner January 20, 2019 17:52

blue-github-bot bot added QA: Unassigned labels Jan 20, 2019

mikeshardmind suggested changes Jan 20, 2019

View reviewed changes

PredaaA and others added 3 commits January 20, 2019 22:55

Black formatting for serverinfo

054b5be

Black formatting fix and Sinbad suggestions

224ea85

Fix the discord.errors.NotFound on server command

fd4549d

Added exception on server command for the phrase "To leave a server, just type its number.".

PredaaA requested a review from tekulvw as a code owner February 1, 2019 02:37

PredaaA added 12 commits February 1, 2019 03:49

Update core_commands.py

d371bde

Delete core_commands.py

3a57ac4

Create core_commands.py

d429b83

Update core_commands.py

419f2c0

Update core_commands.py

f8679c7

Merge pull request #1 from PredaaA/PredaaA-patch-1

4e8c5f7

Update core_commands.py

Delete core_commands.py

3c5abc4

Create core_commands.py

88f6296

Update core_commands.py

becca9f

Update core_commands.py

bf8743b

Little changes on serverinfo command

004833b

- Adding "lurkers" check, for the new feature that are on bot which allow users to join a server in read-only (Works only on verified servers for now) - Adding streaming status. - Adding mobile status with suggestion of Sinbad.

Black style fix

4538768

Tobotimus added the Type: Enhancement Something meant to enhance existing Red features. label Feb 20, 2019

Add verbose for serverinfo and disable lurkers

6ae98fd

I've added a bool that are False by default and sent the original serverinfo command, and if set to True send my edited version. And I've disabled the lurkers detection until this bug (discord/discord-api-docs#855) isn't fixed.

PredaaA added 3 commits May 4, 2019 21:47

Add of India region

930de33

Code cleanup

49cb977

Emojis are not needed to be translated

7b35c1e

Tobotimus removed V3 labels Jun 29, 2019

Merge branch 'V3/develop' into V3/develop

2ce457d

Jackenmen added Category: Bot Core Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. and removed Category: Bot Core labels Jan 16, 2020

mikeshardmind suggested changes Feb 8, 2020

View reviewed changes

redbot/cogs/general/general.py Outdated Show resolved Hide resolved

Update serverinfo

c7c87ba

PredaaA changed the title ~~[V3 General cog] Enhancement of [p]serverinfo command~~ [General] Enhancement of [p]serverinfo command when using a toggle Feb 8, 2020

Changelog.

65a799c

PredaaA requested a review from Twentysix26 as a code owner February 8, 2020 13:51

Merge branch 'V3/develop' into V3/develop

3e6fa5d

PredaaA changed the title ~~[General] Enhancement of [p]serverinfo command when using a toggle~~ [General] Show more details in [p]serverinfo command when using a toggle Feb 8, 2020

Update 2382.enhancement.rst

0e711db

Jackenmen removed the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Mar 15, 2020

Jackenmen self-assigned this Mar 15, 2020

Jackenmen requested changes Mar 15, 2020

View reviewed changes

Jackenmen added this to the 3.3.3 milestone Mar 15, 2020

PredaaA and others added 3 commits March 15, 2020 22:40

Adress Jack's requests changes.

fedcb15

oops

132ca8c

Put guild description first + few last nitpicks

49f5ad9

Jackenmen approved these changes Mar 15, 2020

View reviewed changes

Jackenmen changed the title ~~[General] Show more details in [p]serverinfo command when using a toggle~~ [General] Add toggle to [p]serverinfo that shows more details Mar 15, 2020

Jackenmen merged commit 6128d54 into Cog-Creators:V3/develop Mar 15, 2020

Jackenmen added the Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. label Mar 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[General] Add toggle to `[p]serverinfo` that shows more details #2382

[General] Add toggle to `[p]serverinfo` that shows more details #2382

PredaaA commented Jan 20, 2019 •

edited

Zephyrkul commented Jan 20, 2019

mikeshardmind left a comment

PredaaA commented Feb 6, 2019 •

edited

Zephyrkul commented Feb 6, 2019

PredaaA commented Feb 6, 2019

Tobotimus commented Feb 20, 2019

Kowlin commented Feb 22, 2019

mikeshardmind commented Mar 1, 2019

PredaaA commented Mar 2, 2019

Jackenmen left a comment

[General] Add toggle to [p]serverinfo that shows more details #2382

[General] Add toggle to [p]serverinfo that shows more details #2382

Conversation

PredaaA commented Jan 20, 2019 • edited

Type

Description of the changes

Zephyrkul commented Jan 20, 2019

mikeshardmind left a comment

Choose a reason for hiding this comment

PredaaA commented Feb 6, 2019 • edited

Zephyrkul commented Feb 6, 2019

PredaaA commented Feb 6, 2019

Tobotimus commented Feb 20, 2019

Kowlin commented Feb 22, 2019

mikeshardmind commented Mar 1, 2019

PredaaA commented Mar 2, 2019

Jackenmen left a comment

Choose a reason for hiding this comment

[General] Add toggle to `[p]serverinfo` that shows more details #2382

[General] Add toggle to `[p]serverinfo` that shows more details #2382

PredaaA commented Jan 20, 2019 •

edited

PredaaA commented Feb 6, 2019 •

edited