Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core Commands] remove set owner and set token #2928

Merged
merged 3 commits into from Aug 13, 2019
Merged

[Core Commands] remove set owner and set token #2928

merged 3 commits into from Aug 13, 2019

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Aug 11, 2019

Neither of these commands encourages good security, and their downsides are not comparable to the risks in keeping them.

palmtree5
palmtree5 previously approved these changes Aug 11, 2019
@@ -0,0 +1 @@
The ``set owner`` and ``set token`` commands have been removed in favor of managing server side.
Copy link
Member

@jack1142 jack1142 Aug 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we can call Discord's guild "servers" too, I found this changelog entry a little confusing when I first read it. Perhaps you could change it to "in favor of managing it through command line"?
Edit: I guess this might not make sense currently that we can't actually do it through command line, so I don't know actually, maybe you should ignore my suggested change, though the current sentence is still a little confusing in my opinion 😄

Suggested change
The ``set owner`` and ``set token`` commands have been removed in favor of managing server side.
The ``set owner`` and ``set token`` commands have been removed in favor of managing it through command line.

Copy link
Contributor Author

@mikeshardmind mikeshardmind Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm electing to leave it as-is for now. It is technically possible to change later if needed, but this is clear enough for this particular case.

@Flame442 Flame442 added QA: Passed Type: Removal labels Aug 12, 2019
@mikeshardmind mikeshardmind merged commit 984a97d into Cog-Creators:V3/develop Aug 13, 2019
1 check passed
@mikeshardmind mikeshardmind deleted the set-owner-removal branch Aug 13, 2019
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Aug 13, 2019
@Flame442 Flame442 mentioned this pull request Sep 29, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Passed Type: Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants