[Core Commands] remove set owner and set token #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palmtree5
previously approved these changes
Aug 11, 2019
palmtree5
approved these changes
Aug 11, 2019
Jackenmen
reviewed
Aug 11, 2019
| @@ -0,0 +1 @@ | |||
| The ``set owner`` and ``set token`` commands have been removed in favor of managing server side. | |||
There was a problem hiding this comment.
Since we can call Discord's guild "servers" too, I found this changelog entry a little confusing when I first read it. Perhaps you could change it to "in favor of managing it through command line"?
Edit: I guess this might not make sense currently that we can't actually do it through command line, so I don't know actually, maybe you should ignore my suggested change, though the current sentence is still a little confusing in my opinion 😄
Suggested change
| The ``set owner`` and ``set token`` commands have been removed in favor of managing server side. | |
| The ``set owner`` and ``set token`` commands have been removed in favor of managing it through command line. |
There was a problem hiding this comment.
I'm electing to leave it as-is for now. It is technically possible to change later if needed, but this is clear enough for this particular case.
Flame442
added
QA: Passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither of these commands encourages good security, and their downsides are not comparable to the risks in keeping them.