[Help] Fix embed size calculation for additional text #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flame442
requested changes
Dec 26, 2019
redbot/core/commands/help.py
Outdated
| foot_text = embed_dict["footer"]["text"] | ||
| if foot_text: | ||
| offset += len(foot_text) | ||
| offset += len(embed_dict["description"]) |
There was a problem hiding this comment.
This throws an error any way I try to run [p]help
[2019-12-26 14:30:56] [ERROR] red: Exception in command 'help'
Traceback (most recent call last):
File "<venv>\lib\site-packages\redbot\core\commands\help.py", line 644, in red_help
await ctx.bot.send_help_for(ctx, thing_to_get_help_for)
File "<venv>\lib\site-packages\redbot\core\bot.py", line 436, in send_help_for
return await self._help_formatter.send_help(ctx, help_for)
File "<venv>\lib\site-packages\redbot\core\commands\help.py", line 143, in send_help
await self.format_command_help(ctx, help_for)
File "<venv>\lib\site-packages\redbot\core\commands\help.py", line 233, in format_command_help
await self.make_and_send_embeds(ctx, emb)
File "<venv>\lib\site-packages\redbot\core\commands\help.py", line 303, in make_and_send_embeds
offset += len(embed_dict["description"])
KeyError: 'description'There was a problem hiding this comment.
sigh of course. Give me a sec, I know why that's happening.
| author_info = {"name": f"{ctx.me.display_name} Help Menu", "icon_url": ctx.me.avatar_url} | ||
|
|
||
| # Offset calculation here is for total embed size limit | ||
| # 20 accounts for# *Page {i} of {page_count}* |
There was a problem hiding this comment.
Should half of this be on a separate line or is there just a random extra #?
There was a problem hiding this comment.
Was intended to split the literal code being accounted for from the rest of the comment.
Cog-CreatorsBot
previously requested changes
Dec 26, 2019
Flame442
added
the
QA: Changes Requested
added 2 commits
December 26, 2019 14:55
added 2 commits
December 26, 2019 15:44
Flame442
requested changes
Dec 26, 2019
redbot/core/core_commands.py
Outdated
| """ | ||
| if limit <= 0: | ||
| await ctx.send(_("You must give a positive value!")) | ||
| if limit <= 500: |
There was a problem hiding this comment.
Should be <, otherwise "500" does not work.
There was a problem hiding this comment.
Sorted, thanks.
added 2 commits
December 26, 2019 16:37
Flame442
approved these changes
Dec 26, 2019
Cog-CreatorsBot
approved these changes
Dec 26, 2019
Flame442
added
QA: Passed
Jackenmen
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
Handles the total sum of text in an embed properly.