Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do better with loop cleanup #3245

Merged

Conversation

@mikeshardmind
Copy link
Member

mikeshardmind commented Dec 31, 2019

Description of the changes

It should reduce console noise during cleanup.

Should also fix the issues some people had on windows with a keyboard interrupt hanging rather than quiting.

@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Dec 31, 2019
@mikeshardmind

This comment has been minimized.

Copy link
Member Author

mikeshardmind commented Dec 31, 2019

This isn't review ready. Some of this needs changing, and it's going to be used to cleanup the logic in main more.

@mikeshardmind

This comment has been minimized.

Copy link
Member Author

mikeshardmind commented Jan 1, 2020

This should be ready to go now.

Make some other things coroutines to work with improved design
@mikeshardmind mikeshardmind requested a review from palmtree5 as a code owner Jan 1, 2020
 - see bpo-23057
 - neccessary for windows users
 - nice for consistent support channel info / feature availability
@mikeshardmind mikeshardmind requested a review from Kowlin as a code owner Jan 1, 2020
@mikeshardmind

This comment has been minimized.

Copy link
Member Author

mikeshardmind commented Jan 1, 2020

Handling cleanup properly on windows requires something which was fixed in python3.8 (bpo-23057)

Since we have to update the deps here for this, we'll be doing it for all platforms to ensure feature availability is uniform across platforms

@mikeshardmind

This comment has been minimized.

Copy link
Member Author

mikeshardmind commented Jan 1, 2020

Current PR state disables our pylint check due to PyCQA/pylint#3247

More internal discussion around this happening.

@codeclimate

This comment has been minimized.

Copy link

codeclimate bot commented Jan 1, 2020

Code Climate has analyzed commit ad3a431 and detected 0 issues on this pull request.

View more on Code Climate.

@mikeshardmind mikeshardmind force-pushed the mikeshardmind:better-loop-cleanup branch from 16cfcd0 to c067133 Jan 1, 2020
meh
@Kowlin
Kowlin approved these changes Jan 2, 2020
@mikeshardmind mikeshardmind merged commit a80e200 into Cog-Creators:V3/develop Jan 2, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
codeclimate 83 fixed issues
Details
@mikeshardmind mikeshardmind deleted the mikeshardmind:better-loop-cleanup branch Jan 2, 2020
Drapersniper added a commit to Drapersniper/Red-DiscordBot that referenced this pull request Jan 16, 2020
* do better with loop cleanup

* changelog

* remove redundant line

* Do this a bit better than the initial pass

* Improve windows support

Make some other things coroutines to work with improved design

* Wish we'd have done this right from the start...

* Update deps surrounding this

 - see bpo-23057
 - neccessary for windows users
 - nice for consistent support channel info / feature availability

* dep issue

* Fix tests

* duplication plugin py version

* actually handle this

* Reconfigure some checks with codeclimate, disable pylint for now

* style

* Is my exasperation showing yet?

* handle some stupid stuff

* meh

* dep changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.