Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do better with loop cleanup #3245

Merged
merged 17 commits into from Jan 2, 2020
Merged

do better with loop cleanup #3245

merged 17 commits into from Jan 2, 2020

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Dec 31, 2019

Description of the changes

It should reduce console noise during cleanup.

Should also fix the issues some people had on windows with a keyboard interrupt hanging rather than quiting.

@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Dec 31, 2019
@mikeshardmind
Copy link
Contributor Author

@mikeshardmind mikeshardmind commented Dec 31, 2019

This isn't review ready. Some of this needs changing, and it's going to be used to cleanup the logic in main more.

@Flame442 Flame442 added Type: Enhancement Type: Fix labels Dec 31, 2019
@mikeshardmind
Copy link
Contributor Author

@mikeshardmind mikeshardmind commented Jan 1, 2020

This should be ready to go now.

Make some other things coroutines to work with improved design
@mikeshardmind mikeshardmind requested a review from palmtree5 as a code owner Jan 1, 2020
Michael H added 2 commits Jan 1, 2020
 - see bpo-23057
 - neccessary for windows users
 - nice for consistent support channel info / feature availability
@mikeshardmind mikeshardmind requested a review from Kowlin as a code owner Jan 1, 2020
@mikeshardmind
Copy link
Contributor Author

@mikeshardmind mikeshardmind commented Jan 1, 2020

Handling cleanup properly on windows requires something which was fixed in python3.8 (bpo-23057)

Since we have to update the deps here for this, we'll be doing it for all platforms to ensure feature availability is uniform across platforms

@mikeshardmind mikeshardmind added the Type: Dependency Update label Jan 1, 2020
@mikeshardmind
Copy link
Contributor Author

@mikeshardmind mikeshardmind commented Jan 1, 2020

Current PR state disables our pylint check due to PyCQA/pylint#3247

More internal discussion around this happening.

@Flame442 Flame442 added the Status: Needs Discussion label Jan 1, 2020
@codeclimate
Copy link

@codeclimate codeclimate bot commented Jan 1, 2020

Code Climate has analyzed commit ad3a431 and detected 0 issues on this pull request.

View more on Code Climate.

Kowlin
Kowlin approved these changes Jan 2, 2020
@mikeshardmind mikeshardmind merged commit a80e200 into Cog-Creators:V3/develop Jan 2, 2020
2 checks passed
@mikeshardmind mikeshardmind deleted the better-loop-cleanup branch Jan 2, 2020
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Discussion Type: Bug Type: Dependency Update Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants