do better with loop cleanup #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 31, 2019 10:20
|
This isn't review ready. Some of this needs changing, and it's going to be used to cleanup the logic in main more. |
Flame442
added
Type: Enhancement
|
This should be ready to go now. |
Make some other things coroutines to work with improved design
added 2 commits
January 1, 2020 12:37
- see bpo-23057 - neccessary for windows users - nice for consistent support channel info / feature availability
|
Handling cleanup properly on windows requires something which was fixed in python3.8 (bpo-23057) Since we have to update the deps here for this, we'll be doing it for all platforms to ensure feature availability is uniform across platforms |
mikeshardmind
added
the
Type: Dependency Update
|
Current PR state disables our pylint check due to pylint-dev/pylint#3247 More internal discussion around this happening. |
|
Code Climate has analyzed commit ad3a431 and detected 0 issues on this pull request. View more on Code Climate. |
added 3 commits
January 1, 2020 18:44
Kowlin
approved these changes
Jan 2, 2020
Jackenmen
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
It should reduce console noise during cleanup.
Should also fix the issues some people had on windows with a keyboard interrupt hanging rather than quiting.