Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Warnings] Fix inconsistency for warnreason #3561

Merged
merged 2 commits into from Feb 17, 2020
Merged

[Warnings] Fix inconsistency for warnreason #3561

merged 2 commits into from Feb 17, 2020

Conversation

Dav-Git
Copy link
Contributor

@Dav-Git Dav-Git commented Feb 17, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

[p]unwarn needs Quotes on reasons that are longer than one word whilst [p]warn doesn't. Seems like I overlooked this in #3490

@Dav-Git
Copy link
Contributor Author

Dav-Git commented Feb 17, 2020

Requesting jack since you handled #3490 as well

Jackenmen
Jackenmen approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jackenmen Jackenmen added the Type: Enhancement Something meant to enhance existing Red features. label Feb 17, 2020
@Jackenmen Jackenmen added this to the 3.3.2 milestone Feb 17, 2020
@Jackenmen Jackenmen self-assigned this Feb 17, 2020
@Jackenmen Jackenmen merged commit d7b73eb into Cog-Creators:V3/develop Feb 17, 2020
@Dav-Git Dav-Git deleted the warnings-inconsistency branch February 17, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackenmen Jackenmen Jackenmen approved these changes

@palmtree5 palmtree5 Awaiting requested review from palmtree5

Assignees

@Jackenmen Jackenmen

Labels
Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dav-Git @Jackenmen