Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change wording in VPS providers document #4050

Merged
merged 6 commits into from Jul 9, 2020
Merged

Change wording in VPS providers document #4050

merged 6 commits into from Jul 9, 2020

Conversation

Vexed01
Copy link
Contributor

@Vexed01 Vexed01 commented Jul 8, 2020 •
edited

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Looking at this it doesn't make complete sense. The company and tier are listed, then it says that those companies have free tier VPSes which has already been mentioned.

https://red-discordbot--4050.org.readthedocs.build/en/4050/host-list.html#free-hosting

Stupid author and reviewer of #3916...

@Drapersniper
Copy link
Contributor

I somewhat disagree with the wording here.

The changes imply that AWS is suitable to small bots, rather than the original stating that free tiers are avaliable and those free tiers are suitable.

If anything I'd change:

AWS EC2 Free Tier <https://aws.amazon.com/free/>_ have free tier VPSes suitable for small bots.
AWS EC2 is not always free—it's a 12 month free trial.

to

AWS EC2 <https://aws.amazon.com/free/>_ have free tier VPSes suitable for small bots.
AWS EC2 is not always free—it's a 12 month free trial.

@Vexed01 Vexed01 changed the title [Docs] Fix free hosting wording [Docs] Change free hosting wording Jul 8, 2020
Jackenmen
Jackenmen requested changes Jul 8, 2020
View reviewed changes
docs/host-list.rst Outdated Show resolved Hide resolved
@Jackenmen Jackenmen self-assigned this Jul 8, 2020
@Jackenmen Jackenmen added the QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. label Jul 8, 2020
@Jackenmen Jackenmen added this to the 3.3.10 milestone Jul 8, 2020
@Jackenmen Jackenmen added Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Type: Fix labels Jul 8, 2020
@Vexed01 @Jackenmen
Update docs/host-list.rst
2b541f2 
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
@Jackenmen Jackenmen added QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. and removed QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). labels Jul 8, 2020
Jackenmen
Jackenmen requested changes Jul 8, 2020
View reviewed changes
docs/host-list.rst Outdated Show resolved Hide resolved
@Kowlin Kowlin modified the milestones: 3.3.10, 3.3.11 Jul 9, 2020
Vexed01 and others added 2 commits July 9, 2020 08:51
@Vexed01 @Jackenmen
Update docs/host-list.rst
f9504cc 
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
@Vexed01
fix it
577122c
Jackenmen
Jackenmen approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR.

@Jackenmen Jackenmen added QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). and removed QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. labels Jul 9, 2020
@Jackenmen Jackenmen changed the title [Docs] Change free hosting wording Change wording in VPS providers document Jul 9, 2020
@Jackenmen Jackenmen merged commit cf3636d into Cog-Creators:V3/develop Jul 9, 2020
@Cog-CreatorsBot Cog-CreatorsBot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jul 9, 2020
@Vexed01 Vexed01 deleted the fix-free-hosting branch July 11, 2020 10:22
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Jul 20, 2020
@Jackenmen Jackenmen modified the milestones: 3.3.11, 3.4.0 Aug 3, 2020
@Jackenmen Jackenmen added Changelog Entry: Skipped Changelog entry for this PR is unnecessary. and removed Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. labels Aug 10, 2020
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackenmen Jackenmen Jackenmen approved these changes

@palmtree5 palmtree5 Awaiting requested review from palmtree5

@tekulvw tekulvw Awaiting requested review from tekulvw

Assignees

@Jackenmen Jackenmen

Labels
Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Changelog Entry: Skipped Changelog entry for this PR is unnecessary. QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Vexed01 @Drapersniper @Jackenmen @Kowlin @Cog-CreatorsBot