Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The big intents checklist. #4574

Draft
wants to merge 12 commits into
base: V3/develop
Choose a base branch
from
Draft

The big intents checklist. #4574

wants to merge 12 commits into from

Conversation

Kowlin
Copy link
Member

@Kowlin Kowlin commented Nov 3, 2020

This PR goes over all member and presence intents to ensure that they don't break horrible on Red. While we normally said that we don't want to rely on fetching members. Discord is sadly forcing our hand here, and for now this is the simplest fix we can do.

Querying however makes this easier to handle in bulk and should be used when possible. One of those instances would be mute.

Gonna keep this as a draft for now as this is a big WIP with still several cogs needing manual checking of code and ensuring everything doesn't horrible break.

@Kowlin Kowlin added Type: Optimisation Situations where too much time is necessary to complete the task. Type: Fix Release Blocker This needs handling prior to the next non-hotfix release. Category: Meta This is related to the repository maintenance. labels Nov 3, 2020
@Kowlin Kowlin added this to the 3.4.3 milestone Nov 3, 2020
@Jackenmen Jackenmen removed the Release Blocker This needs handling prior to the next non-hotfix release. label Nov 30, 2020
@Jackenmen Jackenmen modified the milestones: 3.4.4, 3.4.5 Dec 15, 2020
@Jackenmen Jackenmen modified the milestones: 3.4.6, 3.4.7 Jan 17, 2021
@Kowlin Kowlin closed this Feb 12, 2021
@Kowlin Kowlin deleted the pr/intents/part1 branch February 12, 2021 09:16
@Kowlin Kowlin restored the pr/intents/part1 branch February 12, 2021 09:18
@Kowlin Kowlin reopened this Feb 12, 2021
@github-actions github-actions bot added Category: Core - API - Bank This is related to the core Bank API. Category: Bot Core Category: Cogs - CustomCommands This is related to the CustomCommands cog. labels Feb 12, 2021
@github-actions github-actions bot added Category: Cogs - Economy This is related to the Economy cog. Category: Cogs - Mod This is related to the Mod cog. Category: Cogs - Mutes This is related to the Mutes cog. Category: Cogs - Permissions This is related to the Permissions cog. Category: Cogs - Reports This is related to the Reports cog. Category: Cogs - Trivia This is related to the Trivia cog. Category: Cogs - Warnings This is related to the Warnings cog. and removed Category: Meta This is related to the repository maintenance. labels Feb 12, 2021
@Jackenmen Jackenmen modified the milestones: 3.4.13, 3.5.0 Jun 25, 2021
@Jackenmen Jackenmen added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. and removed Work In Progress labels Jul 15, 2021
@Jackenmen Jackenmen modified the milestones: 3.5.0, 3.6.0 Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hbutlercapone Hbutlercapone Hbutlercapone approved these changes

@TrustyJAID TrustyJAID Awaiting requested review from TrustyJAID TrustyJAID will be requested when the pull request is marked ready for review TrustyJAID is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Category: Cogs - CustomCommands This is related to the CustomCommands cog. Category: Cogs - Economy This is related to the Economy cog. Category: Cogs - Mod This is related to the Mod cog. Category: Cogs - Mutes This is related to the Mutes cog. Category: Cogs - Permissions This is related to the Permissions cog. Category: Cogs - Reports This is related to the Reports cog. Category: Cogs - Trivia This is related to the Trivia cog. Category: Cogs - Warnings This is related to the Warnings cog. Category: Core - API - Bank This is related to the core Bank API. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Type: Optimisation Situations where too much time is necessary to complete the task.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kowlin @Hbutlercapone @Jackenmen @Drapersniper