-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle missing schemas/tables in PostgreSQL driver #5855
Merged
Jackenmen
merged 8 commits into
Cog-Creators:V3/develop
from
Jackenmen:tests_and_postgresql_driver_improvements
Oct 13, 2022
Merged
Properly handle missing schemas/tables in PostgreSQL driver #5855
Jackenmen
merged 8 commits into
Cog-Creators:V3/develop
from
Jackenmen:tests_and_postgresql_driver_improvements
Oct 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should ensure that we don't modify the behavior for the case where the key is not present.
Regression test for PostgreSQL driver clear error.
Jackenmen
added
Type: Bug
Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Type: Enhancement
Something meant to enhance existing Red features.
hacktoberfest-accepted
Used to mark a PR as valid Hacktoberfest contribution. DO NOT REMOVE UNTIL END OF NOVEMBER (sic!)!
labels
Oct 1, 2022
github-actions
bot
added
Category: CI
This is related to repository's CI configuration.
Category: Tests
labels
Oct 1, 2022
Kowlin
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing, bot runs fine in pSQL from what I've seen, feel free to merge when ready.
red-githubbot
bot
added
the
Changelog Entry: Pending
Changelog entry for this PR hasn't been added by repo maintainers yet.
label
Oct 13, 2022
Jackenmen
added a commit
to Jackenmen/Red-DiscordBot
that referenced
this pull request
Nov 1, 2022
Drapersniper
pushed a commit
to Drapersniper/Red-DiscordBot
that referenced
this pull request
Nov 27, 2022
Drapersniper
pushed a commit
to Drapersniper/Red-DiscordBot
that referenced
this pull request
Dec 2, 2022
Red-GitHubBot
pushed a commit
to Red-GitHubBot/Red-DiscordBot
that referenced
this pull request
Apr 19, 2023
…g-Creators#5855) (cherry picked from commit a3de616) Co-authored-by: Jakub Kuczys <me@jacken.men>
github-actions
bot
added
the
Category: Core - API - Config
This is related to the `redbot.core.config` module and `redbot.core.drivers` package.
label
Apr 19, 2023
Jackenmen
added a commit
that referenced
this pull request
Apr 19, 2023
) (#6045) Co-authored-by: Jakub Kuczys <me@jacken.men>
Jackenmen
added
Changelog Entry: Added
Changelog entry for this PR has already been added to changelog PR.
and removed
Changelog Entry: Pending
Changelog entry for this PR hasn't been added by repo maintainers yet.
labels
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: CI
This is related to repository's CI configuration.
Category: Core - API - Config
This is related to the `redbot.core.config` module and `redbot.core.drivers` package.
Changelog Entry: Added
Changelog entry for this PR has already been added to changelog PR.
hacktoberfest-accepted
Used to mark a PR as valid Hacktoberfest contribution. DO NOT REMOVE UNTIL END OF NOVEMBER (sic!)!
Type: Bug
Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Type: Enhancement
Something meant to enhance existing Red features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
(cog_name, cog_id)
pair:Have the changes in this PR been tested?
Yes
Proof that the added tests can fail:
https://github.com/jack1142/Red-DiscordBot/actions/runs/3162818621/jobs/5149778704#step:6:58