Use custom groups in config instead of a big list #5880
+109
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Category: Cogs - Alias
Dav-Git
force-pushed
the
5242-migrate_alias_config_to_dicts
branch
from
271bd56
to
821bea5
Compare
…om/Dav-Git/Red-DiscordBot into 5242-migrate_alias_config_to_dicts
|
You should group Config calls to avoid repeated calls to the same scope - alias is one of the few areas of red that these optimisations have a real world benefit |
|
Agreed. Optimizations like this will follow when I have it generally working. |
Kowlin
changed the title
Kowlin
added
Type: Enhancement
|
No idea what broke the docs test... Works on my Machine(TM) and the error in the actions output isn't really telling me much. |
Flame442
added
the
hacktoberfest-accepted
|
I noticed something about a timeout trying to reach a URL in the docs test output, so I just reran the test and it came back positive. Seems like a temporary outage caused it to fail. All set now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Move aliases config from a list per guild to custom groups.
Additionally potentially change the cache structure to better fit the new config model.
Add a migration to migrate existing Alias Data to the new config forma.
Have the changes in this PR been tested?
Yes
This closes #5242