Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos #5989

Merged
merged 4 commits into from Feb 14, 2023
Merged

docs: fix typos #5989

merged 4 commits into from Feb 14, 2023

Conversation

Lioness100
Copy link
Contributor

@Lioness100 Lioness100 commented Feb 14, 2023

Description of the changes

This PR fixes a few random typos (this was a trial run for a CLI I made)
I think "bumpped_shuffle" is a typo, but it was used in a lot of places in the code, so I didn't want to change anything without clearing it with a maintainer.

Also, I know this edits both code and comments, and modifies a lot of different sections of the code, so let me know if you need me to split it up into more modular PRs. :)

Have the changes in this PR been tested?

No

@github-actions github-actions bot added Category: Cogs - Audio This is related to the Audio cog. Category: Cogs - Streams This is related to the Streams cog. Category: Cogs - Mod This is related to the Mod cog. Category: Cogs - Alias This is related to the Alias cog. Category: Cogs - Mutes This is related to the Mutes cog. Category: Cogs - Trivia This is related to the Trivia cog. Category: Cogs - Reports This is related to the Reports cog. Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. Category: Core - Help This is related to our help command and/or HelpFormatter API. Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Category: Core - RPC/ZMQ Related to provided (provisional) API for implementing RPC in cogs Category: Core - API - Other This is related to core APIs that don't have a dedicated label. Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). Category: Core - Other Internals This is related to core internals that don't have a dedicated label. Category: Docs - Install Guides This is related to install guides. Category: Docs - User Guides This is related to user guides (excluding cog guides). Category: Meta This is related to the repository maintenance. Category: Vendored Packages This is related to the packages we vendor (currently just discord.ext.menus). labels Feb 14, 2023
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more accurate than most other automated spellchecking tools that have made PRs to Red, I'll give you that!

@@ -154,7 +154,7 @@ async def triviaset_allowoverride(self, ctx: commands.Context, enabled: bool):
)

@triviaset.command(name="usespoilers", usage="<true_or_false>")
async def trivaset_use_spoilers(self, ctx: commands.Context, enabled: bool):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes in this file are inaccurate, as the command name is the literal triviaset, standing for "trivia setting".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I think my intent was correct but I didn't fix it correctly. The typo was that it's "trivaset" (missing the "i" after the "v"). The problem was that I only fixed the trivia typo and forgot to add "set" with it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yep I see that now. If you want to make that change but keep set in the command name, that would be fine!

redbot/cogs/mutes/mutes.py Outdated Show resolved Hide resolved
@Flame442 Flame442 added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Feb 14, 2023
@Flame442 Flame442 self-assigned this Feb 14, 2023
Lioness100 and others added 2 commits February 13, 2023 17:35
Co-authored-by: Flame442 <34169552+Flame442@users.noreply.github.com>
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Flame442 Flame442 merged commit a89a27c into Cog-Creators:V3/develop Feb 14, 2023
1 check passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Feb 14, 2023
@Lioness100
Copy link
Contributor Author

Np! Just as a note, do you know if "bumpped_shuffle" is a typo?

@Jackenmen Jackenmen added this to the 3.4.19 milestone Apr 19, 2023
@red-githubbot
Copy link

red-githubbot bot commented Apr 19, 2023

Sorry, @Jackenmen, I could not cleanly backport this to 3.4 due to a conflict. Please backport using cherry_picker on command line.

cherry_picker a89a27cadf56b142892a02f8fbb0e0db06c51106 3.4

Jackenmen pushed a commit to Jackenmen/Red-DiscordBot that referenced this pull request Apr 19, 2023
(cherry picked from commit a89a27c)

Co-authored-by: Lioness100 <jchickmm2@gmail.com>
Co-authored-by: Flame442 <34169552+Flame442@users.noreply.github.com>
@red-githubbot
Copy link

red-githubbot bot commented Apr 19, 2023

#6073 is a backport of this pull request to Red 3.4.

Jackenmen added a commit that referenced this pull request Apr 19, 2023
Co-authored-by: Lioness100 <jchickmm2@gmail.com>
Co-authored-by: Flame442 <34169552+Flame442@users.noreply.github.com>
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Apr 20, 2023
Jackenmen pushed a commit to Jackenmen/Red-DiscordBot that referenced this pull request May 5, 2023
Co-authored-by: Flame442 <34169552+Flame442@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Alias This is related to the Alias cog. Category: Cogs - Audio This is related to the Audio cog. Category: Cogs - Mod This is related to the Mod cog. Category: Cogs - Mutes This is related to the Mutes cog. Category: Cogs - Reports This is related to the Reports cog. Category: Cogs - Streams This is related to the Streams cog. Category: Cogs - Trivia This is related to the Trivia cog. Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. Category: Core - API - Other This is related to core APIs that don't have a dedicated label. Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Category: Core - Bot Class This is related to the `redbot.core.bot.Red` class. Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). Category: Core - Help This is related to our help command and/or HelpFormatter API. Category: Core - Other Internals This is related to core internals that don't have a dedicated label. Category: Core - RPC/ZMQ Related to provided (provisional) API for implementing RPC in cogs Category: Docs - Install Guides This is related to install guides. Category: Docs - User Guides This is related to user guides (excluding cog guides). Category: Meta This is related to the repository maintenance. Category: Vendored Packages This is related to the packages we vendor (currently just discord.ext.menus). Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Docs-only Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants