Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with autocomplete in ignored channels/servers #6375

Conversation

TrustyJAID
Copy link
Member

Description of the changes

Resolves #6374 by replacing the text response on an autocomplete interaction with choices stating why the command won't function properly

Have the changes in this PR been tested?

Yes

image

@github-actions github-actions bot added the Category: Core - API - Other This is related to core APIs that don't have a dedicated label. label May 6, 2024
@Flame442
Copy link
Member

Flame442 commented May 6, 2024

Does this also need to be added for the whitelist/blacklist? Does it make more sense to not use interaction_check to block in cases where it is just for autocomplete, not for a full command?

@Flame442 Flame442 added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label May 6, 2024
@Flame442 Flame442 added this to the 3.5.10 milestone May 6, 2024
@Flame442 Flame442 self-assigned this May 6, 2024
@Flame442 Flame442 merged commit 4242a7a into Cog-Creators:V3/develop May 6, 2024
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label May 6, 2024
BenCos17 added a commit to JARVIS-discordbot/Red-DiscordBot-jarvis that referenced this pull request May 11, 2024
* Add Ubuntu 24.04 instructions + support for Fedora 40 (Cog-Creators#6364)

* Update macOS instructions to use default cask (Cog-Creators#6368)

* Fix an issue with autocomplete in ignored channels/servers (Cog-Creators#6375)

---------

Co-authored-by: Jakub Kuczys <me@jacken.men>
Co-authored-by: TrustyJAID <TrustyJAID@gmail.com>
@Jackenmen Jackenmen modified the milestones: 3.5.11, 3.5.10 Jul 10, 2024
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core - API - Other This is related to core APIs that don't have a dedicated label. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check responding to autocomplete interaction: 400 Bad Request - Value must be one of {8}.
3 participants