-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mod] APIify modlogs #672
Closed
Closed
[Mod] APIify modlogs #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As for what needs to be tested:
|
Twentysix26
previously requested changes
Mar 24, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase
palmtree5
force-pushed
the
modlog-rewrite
branch
from
March 24, 2017 19:18
6002475
to
42efaba
Compare
rebase done |
ok, this is actually fixed now |
bump since it's been almost 2 weeks |
This was referenced Apr 5, 2017
Rebasing intensifies |
And done |
Do we want to just hold off on this and incorporate it into V3? |
Closing as this will likely be included in V3. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for easier usage of mod logs by third party cogs by allowing them to be able to register new case types. The mod log can be accessed by other cogs by doing something like
self.modlog = self.bot.get_cog("Mod").modlog
. Then from there, they can useregister_casetype
to add a new case type and then usenew_case
for adding new cases. This does not reset cases at all, but settings related to the modlog feature (i.e. modlog channel and case type settings) would need to be redone by the user after updating if this were merged as is