Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mod] APIify modlogs #672

Closed
wants to merge 3 commits into from
Closed

Conversation

palmtree5
Copy link
Member

This will allow for easier usage of mod logs by third party cogs by allowing them to be able to register new case types. The mod log can be accessed by other cogs by doing something like self.modlog = self.bot.get_cog("Mod").modlog. Then from there, they can use register_casetype to add a new case type and then use new_case for adding new cases. This does not reset cases at all, but settings related to the modlog feature (i.e. modlog channel and case type settings) would need to be redone by the user after updating if this were merged as is

@palmtree5
Copy link
Member Author

palmtree5 commented Mar 22, 2017

As for what needs to be tested:

  • Create a case
  • Specify a reason
  • Edit the case
  • Register a custom case type and try using it

Copy link
Member

@Twentysix26 Twentysix26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

@palmtree5
Copy link
Member Author

rebase done

@palmtree5
Copy link
Member Author

ok, this is actually fixed now

@palmtree5
Copy link
Member Author

bump since it's been almost 2 weeks

@palmtree5
Copy link
Member Author

Rebasing intensifies

@palmtree5
Copy link
Member Author

And done

@tekulvw
Copy link
Member

tekulvw commented Jun 8, 2017

Do we want to just hold off on this and incorporate it into V3?

@tekulvw
Copy link
Member

tekulvw commented Jun 8, 2017

Closing as this will likely be included in V3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants