Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine documentation #11

Merged
merged 23 commits into from
Sep 18, 2023
Merged

Refine documentation #11

merged 23 commits into from
Sep 18, 2023

Conversation

jonw-cogapp
Copy link
Collaborator

@jonw-cogapp jonw-cogapp commented Aug 30, 2023

  • Pivotal ticket: #185595742
  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What does this Pull Request do?

Tooling

  • Adds husky (managing git hooks)
  • Adds lint-staged (managing scope of git hooks)
  • Adds new lint:typecheck for completeness
  • Adds pre-commit hook which will:
    • Run lint-staged, performing specific actions on .ts and .css files
    • Run the typedoc generator if any Typescript files are staged

Code

  • Moved some things around in the constructor to avoid the instanceId incrementing if the viewer didn't initialise
  • Renamed index.ts to StoriiiesViewer.ts for clarity
  • Added JSDoc comments (primarily to improve output of typedoc)
    • N.B. Using JSDoc for readonly was preferable to the TypeScript keyword due to some things unavoidably needing to be assigned outside of the constructor or inside the .then(), which would result in a tsc compile error

Bundle output

  • Changed the output directories to umd and esm, this seemed preferable

Documentation

  • Made tables full width (in admittedly as slightly hacky way)
  • Added bit about what shape of manifests we support
  • Generated typedoc files

Other notes

Test coverage

Yes/No: Are changes in this pull-request covered by:

  • Cypress tests?

Interested parties

@tristanr-cogapp

@jonw-cogapp jonw-cogapp changed the title Refine documentation 185595742 Refine documentation Aug 30, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@iainb-cogapp
Copy link
Contributor

@jonw-cogapp I've suggested a couple of minor tweaks to the Readme but otherwise looks great

@jonw-cogapp
Copy link
Collaborator Author

@iainb-cogapp Thanks, I've implemented your suggestions 👍

@jonw-cogapp
Copy link
Collaborator Author

@tristanr-cogapp Let me know after you've had a read through this if you have any feedback

Copy link
Contributor

@tristanr-cogapp tristanr-cogapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please see typo suggestions inline in the README.

Also, shouldn't there be a link somewhere in the README to all the API docs?

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jonw-cogapp jonw-cogapp merged commit 64e19cd into develop Sep 18, 2023
1 check passed
@jonw-cogapp jonw-cogapp deleted the refine-documentation-185595742 branch September 18, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants