-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine documentation #11
Conversation
@jonw-cogapp I've suggested a couple of minor tweaks to the Readme but otherwise looks great |
@iainb-cogapp Thanks, I've implemented your suggestions 👍 |
@tristanr-cogapp Let me know after you've had a read through this if you have any feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please see typo suggestions inline in the README.
Also, shouldn't there be a link somewhere in the README to all the API docs?
What does this Pull Request do?
Tooling
lint:typecheck
for completeness.ts
and.css
filesCode
instanceId
incrementing if the viewer didn't initialiseindex.ts
toStoriiiesViewer.ts
for clarity.then()
, which would result in a tsc compile errorBundle output
umd
andesm
, this seemed preferableDocumentation
Other notes
new default(config)
, which is patently incorrect.Test coverage
Yes/No: Are changes in this pull-request covered by:
Interested parties
@tristanr-cogapp