feat: use script message to control the osc logo display in idle state #70
Conversation
|
The implementation of some osc scripts does not have the This pr can work better for such these osc scripts: tomasklaen/uosc#293, sosc. |
dyphire
changed the title
|
I not sure that only sending the message while idle is a good idea. What if the browser is opened while idle but only closed after something has started playing? The idlescreen will be left disabled even though we don't want it to be. It doesn't seem like enabling/disabling the idlescreen is a very intensive operation for the OSC, so it is probably fine to just always send the script messages. However I do think there should be a script-opt in file-browser to control whether or not we send these messages. A simple |
Ah, that's true. I missed it. |
Done. |
file-browser.lua
Outdated
| @@ -89,6 +89,9 @@ local o = { | |||
| --directory to load external modules - currently just user-input-module | |||
| module_directory = "~~/script-modules", | |||
|
|
|||
| --enable script-message to control the idlescreen | |||
There was a problem hiding this comment.
| --enable script-message to control the idlescreen | |
| --turn the OSC idle screen off and on when opening and closing the browser |
file_browser.conf
Outdated
| @@ -84,6 +84,9 @@ addon_directory=~~/script-modules/file-browser-addons | |||
| #directory to load external modules - currently just user-input-module | |||
| module_directory=~~/script-modules | |||
|
|
|||
| #enable script-message to control the idlescreen | |||
There was a problem hiding this comment.
| #enable script-message to control the idlescreen | |
| #turn the OSC idle screen off and on when opening and closing the browser |
ref: mpv-player/mpv@ec236f7, #55 This will allow automatic control the logo display of osc scripts with have the `osc-idlesereen` feature. However, since this feature is a recently added function, let's keep `utils.shared_script_property_set`.
ref: #55, mpv-player/mpv@ec236f7
This will allow automatic control the logo display of osc scripts with have the
osc-idlesereenfeature.However, since this feature is a recently added function, let's keep
utils.shared_script_property_set.