Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve problem with removing image and skills when editing one or th… #66

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Sanderkk
Copy link
Collaborator

@Sanderkk Sanderkk commented Apr 4, 2019

Profile picture is no longer deleted if a picture is not uploaded.
Skills not removed when trying to update image or skills.

@Sanderkk Sanderkk requested a review from jonaengs April 4, 2019 17:00
@codecov-io
Copy link

Codecov Report

Merging #66 into dev will decrease coverage by 0.06%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #66      +/-   ##
==========================================
- Coverage   89.75%   89.69%   -0.07%     
==========================================
  Files          44       44              
  Lines         908      912       +4     
==========================================
+ Hits          815      818       +3     
- Misses         93       94       +1
Impacted Files Coverage Δ
user_profile/forms.py 73.68% <100%> (+3.09%) ⬆️
user_profile/views.py 93.33% <75%> (-3.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e331660...d7f6d2a. Read the comment docs.

@haavarop
Copy link
Member

Hva er status på denne? Kan vi merge den?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants