Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for configurable azure sas tokens #7

Closed
deepshikha-jha opened this issue Jan 10, 2019 · 11 comments
Closed

Support for configurable azure sas tokens #7

deepshikha-jha opened this issue Jan 10, 2019 · 11 comments
Assignees
@alkadi

Comments

@deepshikha-jha
Copy link

No description provided.

@alkadi alkadi self-assigned this Jan 24, 2019
@alkadi
Copy link
Contributor

alkadi commented Feb 2, 2019

Can you elaborate on this?

@deepshikha-jha
Copy link
Author

Cogniac/cogniac-sdk-py@ffef150

@alkadi
Copy link
Contributor

alkadi commented Feb 7, 2019

Ok so we just upload the token to the tenant, it isn't present in your API docs BTW: https://cogniac.readme.io/docs/tenants

@deepshikha-jha
Copy link
Author

I will update the docs

@alkadi
Copy link
Contributor

alkadi commented Feb 12, 2019

Thank you, please report back when you do.

@alkadi
Copy link
Contributor

alkadi commented Mar 18, 2019

@deepshikha-jha any updates on the documentation? In the python code I see "azure_sas_tokens", does that mean it is an array of tokens? Any example usage you can share with me so I can implement this correctly? Thanks. My tenant doesn't have this field.

@alkadi
Copy link
Contributor

alkadi commented Apr 3, 2019

Any updates here? @deepshikha-jha ?

@deepshikha-jha
Copy link
Author

@wskish any thoughts on this ?

@wskish
Copy link
Contributor

wskish commented Apr 5, 2019 •
edited

It is currently just a list of tokens. It would be better to have a more developed interface for crud ops on individual tokens but we started here with just a list for expediency. I just changed your role in CsharpSDK tenant to tenant_admin which should allow you to read/write the field.

@alkadi
Copy link
Contributor

alkadi commented Apr 6, 2019

Thank you @wskish , so this is just a string field like the domain_unit for media, I can write any string value to it and read any string value from it, there is no validation process is there?

@alkadi
Copy link
Contributor

alkadi commented May 23, 2019

Azure SAS Token and Tenant updating implemented in SDK 1.0.0.11 available in NuGet 1.0.12

@alkadi alkadi closed this as completed May 23, 2019
alkadi added a commit that referenced this issue May 23, 2019
@alkadi
* Fixed issue #15 (#15)
a4bbbf7 
* Fixed issue #7 (#7)
* Added 'UpdateTenant' function to the 'Connection' class
* Updated the 'Tenant' class with new properties
* CogniacCSharpSDK.dll is now version 1.0.0.11

Signed-off-by: Al Alkadi <al@ieee.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alkadi alkadi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wskish @alkadi @deepshikha-jha