This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
AEM API refactor proposal #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored FieldType to string constants & renamed it to Fields; simplified DialogField as there is no need for the getType method anywhere
Now, there's a single controller interface/implementation and actions have two common interfaces instead of domain-specific duplicates
Shaihuludus
suggested changes
Nov 13, 2018
| @@ -41,13 +42,14 @@ | |||
|
|
|||
| @Override | |||
| protected void configure() { | |||
| bind(SiteAdminController.class).to(AemSiteAdminController.class); | |||
| bind(Controller.class).to(BobcatController.class); | |||
There was a problem hiding this comment.
If this is the only controller then it should be in AemCore module
|
|
||
| @Override | ||
| @Step("Login to AEM and open page {aemAuthorPage.fullUrl}") | ||
| public void login(AemAuthorPage aemAuthorPage) { |
There was a problem hiding this comment.
Still think, it is a good use case
…n to DefaultController
…, updated wording around Actions
…ions to be injected
Shaihuludus
approved these changes
Nov 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the new AEM API a bit:
FieldTypeinterfaceMotivation and Context
Types of changes
Checklist: