Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of information when max header size is exceeded #480

Open
jwadolowski opened this issue Jan 15, 2019 · 0 comments
Open

Lack of information when max header size is exceeded #480

jwadolowski opened this issue Jan 15, 2019 · 0 comments

Comments

@jwadolowski
Copy link

Bug description

knot.x doesn't inform that max HTTP header size was exceeded. knotx.log contains no information about that (tested with INFO and DEBUG log levels). Additionally 400 response is not logged in knotx-access.log file.

knot.x version: 1.4.0 and 1.5.0

Steps to reproduce

  1. Download knot.x ACME example from here (either 1.4.0 or 1.5.0)
  2. Run knot.x: ./bin/knotx run-knotx
  3. Send HTTP request with long Cookie header
$ curl http://localhost:8092/whatever -H "Cookie: test=$(openssl rand -base64 6093 | tr -d "\n")" -o /dev/null -SsD -
HTTP/1.1 404 Not Found
X-Server: Knot.x-Example
Content-Type: text/plain
Content-Length: 20
  1. Send even longer cookie
$ curl http://localhost:8092/whatever -H "Cookie: test=$(openssl rand -base64 6094 | tr -d "\n")" -o /dev/null -SsD -
HTTP/1.1 400 Bad Request

Expected behavior

  • knot.x should clearly point out in knotx.log that max header size was exceeded. Right now there's no such information whatsoever
  • 400 responses should be logged in knotx-access.log file

Screenshots

N/A

Additional context

The issue got discovered by accident, because we had to increase max header size in the past for Apache (one of the endpoints we talk to sets quite long cookies that exceed 8192 default vert.x limit). @Skejven pointed out we can increased that in server.conf via maxHeaderSize = 16384 option and this is what we did. That doesn't change the fact that it'd quite hard to debug if we haven't had that situation with Apache before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant