Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make page model driver override work with lazy elements #29

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Make page model driver override work with lazy elements #29

merged 2 commits into from
Feb 1, 2022

Conversation

twalshcsv
Copy link
Contributor

Closes #28

@twalshcsv twalshcsv added the bug Something isn't working label Feb 1, 2022
@twalshcsv twalshcsv requested review from FermJacobCSV and a user February 1, 2022 22:08
@twalshcsv twalshcsv requested a review from a team as a code owner February 1, 2022 22:08
@twalshcsv twalshcsv self-assigned this Feb 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

12.5% 12.5% Coverage
0.0% 0.0% Duplication

ghost
ghost approved these changes Feb 1, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@twalshcsv twalshcsv merged commit 0e477b4 into main Feb 1, 2022
@twalshcsv twalshcsv deleted the bug/pageModelDriverOverride branch February 1, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FermJacobCSV FermJacobCSV Awaiting requested review from FermJacobCSV

Assignees

@twalshcsv twalshcsv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page model OverrideWebDriver is not respected by lazy elements
1 participant
@twalshcsv