-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/amm migration script & in-flight config disable #252
Feat/amm migration script & in-flight config disable #252
Conversation
Tested and confirmed working as expected when running from source, pending test on docker build. Currently blocked by the following error when starting a docker instance after creating a docker image based from the feature branch: Traceback (most recent call last):
File "bin/hummingbot_quickstart.py", line 18, in <module>
from hummingbot.client.config.config_helpers import (
ImportError: cannot import name 'create_yml_files' from 'hummingbot.client.config.config_helpers' (/home/hummingbot/hummingbot/client/config/config_helpers.py) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RC-13, I have addressed the issue you flagged. Those messages should not appear anymore. Please test the migration and use of celo and kraken one more time. They should now migrate properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest commit looks good to me. I no longer see the last flagged error by Clinton. No notable error as well on connection/balance and running strategies on source and docker build.
Test Summary
-Build a docker image based on the feature branch
-Create a docker instance using the image
-Start the client/setup password
-Create/Import strategy
-Start the strategy
-Configure parameter on the fly
-Stop the strategy and configure the global parameters
-Restart the strategy
-Create a new Avellaneda MM strategy and start
-Configure the parameter while the strategy is running
-Stop the strategy and configure the parameters
-Restart the strategy
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR adds a config migration step for AMM, as well as disables the ability to configure a Pydantic strategy config while the strategy is running (which currently is not fully fleshed out and may lead to errors).
Tests performed by the developer:
Tips for QA testing:
development