refactor / adapts Avellaneda config map for pydantic #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config map introduced in this PR is a proof of concept for the new approach to configs using pydantic. It adopts @aarmoa's suggestion to use nested models as a method of solving the interdependencies issues present with some config variables.
|
This pull request has been linked to Shortcut Story #21823: Create Avellaneda configuration schema. |
aarmoa
suggested changes
Feb 18, 2022
Comment on lines
21
to
24
| class ExecutionTimeframe(str, ClientConfigEnum): | ||
| infinite = "infinite" | ||
| from_date_to_date = "from_date_to_date" | ||
| daily_between_times = "daily_between_times" |
There was a problem hiding this comment.
Is this enum required? Wouldn't it be better to have the a class variable "description" or "title" in each of the model classes to store the string?
There was a problem hiding this comment.
I've replaced the enum for a dictionary as suggested below
hummingbot/strategy/avellaneda_market_making/avellaneda_market_making_config_map_pydantic.py
Outdated
Show resolved
Hide resolved
hummingbot/strategy/avellaneda_market_making/avellaneda_market_making_config_map_pydantic.py
Outdated
Show resolved
Hide resolved
hummingbot/strategy/avellaneda_market_making/avellaneda_market_making_config_map_pydantic.py
Outdated
Show resolved
Hide resolved
hummingbot/strategy/avellaneda_market_making/avellaneda_market_making_config_map_pydantic.py
Outdated
Show resolved
Hide resolved
hummingbot/strategy/avellaneda_market_making/avellaneda_market_making_config_map_pydantic.py
Outdated
Show resolved
Hide resolved
dennisocana
changed the title
Co-authored-by: Abel Armoa <30988000+aarmoa@users.noreply.github.com>
…ydantic' into refactor/avellaneda_config_map_pydantic
aarmoa
reviewed
Feb 22, 2022
test/hummingbot/strategy/avellaneda_market_making/test_config.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Abel Armoa <30988000+aarmoa@users.noreply.github.com>
…ydantic' into refactor/avellaneda_config_map_pydantic
|
I've added a small cleanup commit that I noticed while taking another look at the class |
aarmoa
approved these changes
Feb 24, 2022
The config map introduced in this PR is a proof of concept for the new approach to configs using pydantic. It adopts @aarmoa's suggestion to use nested models as a method of solving the interdependencies issues present with some config variables.
Co-authored-by: Abel Armoa <30988000+aarmoa@users.noreply.github.com>
Co-authored-by: Abel Armoa <30988000+aarmoa@users.noreply.github.com>
petioptrv
changed the base branch from
development
to
feat/config_management_refactoring
…ydantic' into refactor/avellaneda_config_map_pydantic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR introduces a proof of concept for the new approach to defining config maps using pydantic.
It adopts @aarmoa's suggestion to use nested models to address the config variables' interdependencies problem.
Tests performed by the developer:
Tests cover the new functionalities introduced in the proof of concept, plus the functionality already previously covered by existing test.
This PR assumes that the model instance will be directly passed to the strategy, so it does not include a test to flatten the model dictionary in preparation for the current approach to the
init_paramsfunction (config vars passed in as kwargs).Tips for QA testing:
N/A
[ch21823]