Added support for deposit and withdrawal history #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. I'll take a look at this later on tonight.
…On 18 Dec 2017 2:22 pm, "e1ace" ***@***.***> wrote:
Some API calls were missing. They json response does not seem to match the
bittrex documentation but this implementation works.
First time using github so sorry if I'm doing anything incorrectly.
------------------------------
You can view, comment on, or merge this pull request online at:
#12
Commit Summary
- Added support for deposit and withdrawal history
- Removed incorrect comments
File Changes
- *M* src/Bittrex.Api.Client/BittrexClient.cs
<https://github.com/Coinio/Bittrex.Api.Client/pull/12/files#diff-0>
(45)
- *A* src/Bittrex.Api.Client/Models/DepositHistory.cs
<https://github.com/Coinio/Bittrex.Api.Client/pull/12/files#diff-1>
(16)
- *A* src/Bittrex.Api.Client/Models/WithdrawalHistory.cs
<https://github.com/Coinio/Bittrex.Api.Client/pull/12/files#diff-2>
(15)
Patch Links:
- https://github.com/Coinio/Bittrex.Api.Client/pull/12.patch
- https://github.com/Coinio/Bittrex.Api.Client/pull/12.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#12>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGcI8SQauN6bbtko2gyCPiyUUmjZPxjOks5tBnUZgaJpZM4RFibL>
.
|
Coinio
approved these changes
Dec 20, 2017
|
I've merged your pull request into the project. I might tweak the methods very slightly to use the BuildParameter() method like the other methods but otherwise all good and thanks for the contribution. :) The nuget package version 1.1.1 should include your changes once it is available on nuget.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some API calls were missing. They json response does not seem to match the bittrex documentation but this implementation works.
First time using github so sorry if I'm doing anything incorrectly.