Various improvements #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structor to remain backwards compatible.
Coinio
approved these changes
Dec 2, 2017
There was a problem hiding this comment.
Thanks! I really appreciate the changes.
I may tweak the Readme a bit, i.e. remove the ConfigureAwait (JUST from the readme file) as it 'might' cause a new developer an issue if they are using the client in the context of a desktop client application or something similar.
|
I'll update the nuget package with these changes tomorrow. I need to automate that but I didn't think anyone would actually use this. :) |
|
@Coinio I was just playing around and searched for a .net client. I honestly just picked the first of which I found the source. The package seems simple with no dependencies which I why I picked it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements, see individual commits.