Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recover wallets funds #28

Merged
merged 8 commits into from May 9, 2019
Merged

recover wallets funds #28

merged 8 commits into from May 9, 2019

Conversation

haythemsellami
Copy link
Member

A script to send back ETH balance from generated wallets to Coinsence wallet

@haythemsellami haythemsellami requested a review from bumi May 8, 2019 10:27
bumi
bumi requested changes May 8, 2019
View reviewed changes
Copy link
Contributor

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great.

but as it is a script used in the terminal I would move it to scripts?

and it seems you're using 4 spaces as indentation? in the other files we have 2 spaces I think.

lib/http/utils/recover-funds.js Outdated Show resolved Hide resolved
lib/http/utils/recover-funds.js Outdated Show resolved Hide resolved
@haythemsellami haythemsellami requested a review from bumi May 8, 2019 13:13
bumi
bumi reviewed May 8, 2019
View reviewed changes
scripts/recover-funds.js Outdated Show resolved Hide resolved
bumi
bumi requested changes May 8, 2019
View reviewed changes
scripts/recover-funds.js Outdated Show resolved Hide resolved
bumi
bumi reviewed May 9, 2019
View reviewed changes
scripts/recover-funds.js Outdated Show resolved Hide resolved
@bumi
error handling
32495d2 
Co-Authored-By: Michael Bumann <hello@michaelbumann.com>
@haythemsellami haythemsellami changed the title [WIP] recover wallets funds recover wallets funds May 9, 2019
@haythemsellami haythemsellami merged commit 25da8c7 into master May 9, 2019
@kredits-dao
Copy link

kredits-dao bot commented May 9, 2019

Thanks for your contribution! 500K are on the way to @haythem96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bumi bumi bumi approved these changes

Assignees
No one assigned
Labels
kredits-1 kredits-claimed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haythemsellami @bumi