You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my case I had a jar that had no zip END header, which of course leads to the jar not being usable. However the UI does not make this clear right away (other than the loading freezing very early) and the only thing making this fact apparent is the output of the console. Perhaps maybe give a warning in that case?
Example jar that causes this issue (renamed to .zip due to github's file extension limitation; I also own all rights to it) proof-of-concept.zip
The text was updated successfully, but these errors were encountered:
If anyone is aware of some ZIP libraries, or any different handling than what we do now (NIO?), for Java that handle this I can take a look at this. The default ZIP classes error out on the constructor, so its not really possible to cleanly work around this.
Crash since it reads the whole file before letting you visit each sub-item
java.util.zip.ZipException: error in opening zip file
at java.util.zip.ZipFile.open(Native Method)
at java.util.zip.ZipFile.<init>(ZipFile.java:225)
at java.util.zip.ZipFile.<init>(ZipFile.java:155)
at java.util.zip.ZipFile.<init>(ZipFile.java:169)
In my case I had a jar that had no zip END header, which of course leads to the jar not being usable. However the UI does not make this clear right away (other than the loading freezing very early) and the only thing making this fact apparent is the output of the console. Perhaps maybe give a warning in that case?
Example jar that causes this issue (renamed to .zip due to github's file extension limitation; I also own all rights to it) proof-of-concept.zip
The text was updated successfully, but these errors were encountered: