Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add live search to searches [WIP] #607

Draft
wants to merge 2 commits into
base: dev3
Choose a base branch
from
Draft

Add live search to searches [WIP] #607

wants to merge 2 commits into from

Conversation

Amejonah1200
Copy link

@Amejonah1200 Amejonah1200 commented Sep 25, 2022 •
edited

recaf
TODO:

  • Use Virtualized Context
  • Implement for other searches
  • Make Result also contain where specifically the match occurred (useful for RegEx)

@Col-E Col-E added enhancement 3.X ux User interface/experience specific labels Sep 25, 2022
@Col-E
Copy link
Owner

Col-E commented Sep 25, 2022

Skipping a few other formatting comments, as I'll just apply the formatter when merging.

Amejonah1200 added a commit to Amejonah1200/Recaf that referenced this pull request Oct 2, 2022
@Amejonah1200
Apply requested changes
7ea6b35 
- Col-E#607 (comment)
- Col-E#607 (comment)
- Col-E#607 (comment)
- Col-E#607 (comment)
Amejonah1200 added a commit to Amejonah1200/Recaf that referenced this pull request Oct 2, 2022
@Amejonah1200
Apply requested changes
244dbbe 
- Col-E#607 (comment)
- Col-E#607 (comment)
- Col-E#607 (comment)
- Col-E#607 (comment)
- Col-E#607 (comment)
Amejonah1200 added a commit to Amejonah1200/Recaf that referenced this pull request Oct 2, 2022
@Amejonah1200
Apply requested changes
0f4867c 
- Col-E#607 (comment)
- Col-E#607 (comment)
- Col-E#607 (comment)
- Col-E#607 (comment)
- Col-E#607 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Col-E Col-E Col-E requested changes

Assignees
No one assigned
Labels
3.X enhancement ux User interface/experience specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Amejonah1200 @Col-E