fixed getMultiple endpoint issues

src/getMultiple.js

@@ -1,15 +1,15 @@
 const is = require("is_js");
 const lambda = require("./util/lambda");
 const { getItems } = require("./util/persistence");
-const { isurl, assert } = require("./util/util");
+const { isurl, assert, unique } = require("./util/util");
 
 module.exports.fn = lambda(async (event, success) => {
-  assert(is.array(event.body), "getMultiple requires an array");
-  assert(event.body.every(isurl), "getMultiple requires an array of URLs");
+  const urls = JSON.parse(event.body);
 
-  // limit the query to 100 URLs
-  const urls = event.body.slice(0, 100);
+  assert(is.array(urls), "getMultiple requires an array");
+  assert(urls.every(isurl), "getMultiple requires an array of URLs");
 
-  const items = await getItems(urls);
+  // limit the query to 100 URLs
+  const items = await getItems(unique(urls.slice(0, 100)));
   success(items);
 });

src/getMultiple.test.js

@@ -14,7 +14,16 @@ jest.setMock("./util/persistence", {
 const getMultiple = require("./getMultiple").fn;
 
 test("returns the correct response", done => {
-  const urls = ["google.com", "microsoft.com"];
+  const urls = JSON.stringify(["google.com", "microsoft.com"]);
+  getMultiple({ body: urls }, undefined, (error, response) => {
+    const body = JSON.parse(response.body);
+    expect(body.length).toBe(2);
+    done();
+  });
+});
+
+test("removes duplicate URLs", done => {
+  const urls = JSON.stringify(["google.com", "google.com", "microsoft.com"]);
   getMultiple({ body: urls }, undefined, (error, response) => {
     const body = JSON.parse(response.body);
     expect(body.length).toBe(2);
@@ -32,9 +41,9 @@ test("validates that the request is an array", done => {
 test("limits the request to 100 URLs", done => {
   const urls = [];
   for (var i = 0; i < 200; i++) {
-    urls.push("google.com");
+    urls.push("google.com/" + i);
   }
-  getMultiple({ body: urls }, undefined, (error, response) => {
+  getMultiple({ body: JSON.stringify(urls) }, undefined, (error, response) => {
     const body = JSON.parse(response.body);
     expect(body.length).toBe(100);
     done();

src/util/util.js

@@ -5,6 +5,8 @@ const isurl = url => url.match(/^http:\/\/localhost:\d*\/?$/) || is.url(url);
 
 const clamp = (value, lower, upper) => Math.max(lower, Math.min(value, upper));
 
+const unique = items => Array.from(new Set(items));
+
 const assert = (truth, message) => {
   if (!truth) {
     throw new Error(`assertion failure: ${message}`);
@@ -33,5 +35,6 @@ module.exports = {
   clamp,
   assert,
   getSourceUrl,
-  normalizeUrl
+  normalizeUrl,
+  unique
 };

test/multiple.json

@@ -1,9 +1,6 @@
 {
   "headers": {
-    "Referer": "http://www.google.com"
+    "Referer": "www.google.com"
   },
-  "body": [
-    "http://www.google.com",
-    "http://www.google.com"
-  ]
+  "body": "[\"www.google.com\", \"www.colineberhardt.com\"]"
 }