Skip to content

Commit

Permalink
dmicheck: update Memory Device type 17 size/version check (LP: #1892479)
Browse files Browse the repository at this point in the history
BugLink: https://bugs.launchpad.net/fwts/+bug/1892479

Update size check according to SMBIOS specfication [1], page 99, Table 75
that states:

"Length of the structure, 15hfor version 2.1, 1Bh for version 2.3,
 1Ch for version 2.6, 22h for version 2.7, 28h for version 2.8,
 54h for version 3.2, 5Ch for version 3.3 and later"

Ref: [1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0.pdf

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Alex Hung <alex.hung@canonical.com>
Acked-by: Ivan Hu <ivan.hu@canonical.com>
  • Loading branch information
Colin Ian King authored and Alex Hung committed Aug 24, 2020
1 parent f40fb64 commit b4f1e48
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/dmi/dmicheck/dmicheck.c
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,8 @@ static const fwts_dmi_type_length type_info[] = {
{ 17, 0x207, 0x206, 0x1c },
{ 17, 0x208, 0x207, 0x22 },
{ 17, 0x302, 0x208, 0x28 },
{ 17, 0x303, 0x302, 0x54 },
{ 17, MAX_VERSION, 0x303, 0x5c },
{ 19, 0x207, 0x201, 0xf },
{ 19, MAX_VERSION, 0x207, 0x1f },
{ 20, 0x207, 0x201, 0x13 },
Expand Down

0 comments on commit b4f1e48

Please sign in to comment.