ft: Enable deep-links #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we also need to set this up on our domains: |
Codecov Report
@@ Coverage Diff @@
## development #343 +/- ##
===============================================
+ Coverage 66.55% 68.78% +2.22%
===============================================
Files 157 157
Lines 4010 4017 +7
===============================================
+ Hits 2669 2763 +94
+ Misses 1341 1254 -87
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Yes we do, we could pass it via CI |
Screen.Recording.2023-01-20.at.19.44.21.mov |
wizlif
requested review from
Xazin,
a team and
phalcorine
and removed request for
a team
Simulator.Screen.Recording.-.iPhone.13.-.2023-01-28.at.21.19.35.mp4 |
wizlif
force-pushed
the
ft/setup-deeplinks
branch
from
b4f049e
to
eb1debb
Compare
Xazin
previously approved these changes
Feb 23, 2023
…logging-auth-repo fix: add manual logging to auth repo
Signed-off-by: Isaac Obella <wizlif@users.noreply.github.com>
Signed-off-by: Isaac Obella <wizlif@users.noreply.github.com>
Signed-off-by: Isaac Obella <wizlif@users.noreply.github.com>
wizlif
force-pushed
the
ft/setup-deeplinks
branch
from
f59cc83
to
25f89ae
Compare
Xazin
reviewed
Apr 1, 2023
| run: | | ||
| echo "$DEEPLINK_XCCONFIG_CONTENTS" > ios/Flutter/Deeplink.xcconfig | ||
| env: | ||
| DEEPLINK_XCCONFIG_CONTENTS: ${{ secrets.IOS_DEEPLINK_CONFIG }} |
There was a problem hiding this comment.
What do we input here? Different ones depending on Development/Production? DM me on Slack
Xazin
approved these changes
Apr 1, 2023
|
We need to rebase this, and then we should be able to merge. |
|
Let me cherry pick the major changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables ability to use deep-links to traverse the app routes.
Android
iOs
Android Preview
Screen.Recording.2023-01-17.at.09.08.50.mov
iOs Preview
Screen.Recording.2023-01-17.at.09.23.58.mov
Screen.Recording.2023-01-17.at.09.29.00.mov
Closes #287