Feat/gh 357/account information screen #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazin
reviewed
Mar 16, 2023
lib/presentation/account_information/widgets/contact_info_widgets/build_email_row.dart
Outdated
Show resolved
Hide resolved
lib/presentation/account_information/widgets/contact_info_widgets/build_email_row.dart
Outdated
Show resolved
Hide resolved
lib/presentation/account_information/widgets/contact_info_widgets/build_email_row.dart
Outdated
Show resolved
Hide resolved
wizlif
reviewed
Mar 18, 2023
| final IProfileRepository _profileRepository; | ||
| PersonalInformationBloc(this._profileRepository) : super(_Fetching()) { | ||
| _profileRepository.getUserProfile().then((profileOrFailure) { | ||
| profileOrFailure.fold((l) {}, (profile) { |
There was a problem hiding this comment.
You should handle the error state as well.
There was a problem hiding this comment.
I'm not sure how we should deal with this error, since you shouldn't be able to reach the Account Information screen without being logged in, and thus having a profile.
What do you think is best @wizlif ?
I see these few options:
- Create an anonymous version of the Widget that uses the profile (We'll use that as an error widget)
- Show loading state (We'll implement a shimmer version), and a snackbar with an error
lib/presentation/account_information/widgets/contact_info_widgets/build_email_row.dart
Show resolved
Hide resolved
| mainAxisAlignment: MainAxisAlignment.spaceBetween, | ||
| children: [ | ||
| Text( | ||
| '${location?.name ?? "No"}, ${location?.code ?? "Country"}', |
There was a problem hiding this comment.
Create a getter in the location model to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created the information page:
Notes: I couldn't find any bugs but need to review