Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/auth-routing #409

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Conversation

wizlif
Copy link
Collaborator

@wizlif wizlif commented Jul 4, 2023

  • Bind go_router route listener to AuthBloc.
  • Handle redirects

Signed-off-by: Isaac Obella <wizlif@users.noreply.github.com>
Signed-off-by: Isaac Obella <wizlif@users.noreply.github.com>
@wizlif wizlif requested review from Xazin and sarahaudina July 4, 2023 15:11
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #409 (e06c70d) into development (b012f1a) will decrease coverage by 0.09%.
The diff coverage is 36.36%.

@@               Coverage Diff               @@
##           development     #409      +/-   ##
===============================================
- Coverage        66.71%   66.63%   -0.09%     
===============================================
  Files              159      160       +1     
  Lines             4149     4166      +17     
===============================================
+ Hits              2768     2776       +8     
- Misses            1381     1390       +9     
Impacted Files Coverage Δ
lib/main.dart 0.00% <0.00%> (ø)
lib/presentation/auth/unauthenticated_screen.dart 0.00% <ø> (ø)
lib/presentation/core/app_widget.dart 0.00% <0.00%> (ø)
lib/presentation/routes/app_pages.dart 100.00% <ø> (ø)
lib/presentation/routes/refresh_stream.dart 27.27% <27.27%> (ø)
lib/presentation/routes/app_routes.dart 72.52% <55.55%> (-2.18%) ⬇️
lib/core/config/network_config.dart 75.00% <75.00%> (+8.33%) ⬆️
lib/domain/profile/user_profile.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Xazin
Xazin previously approved these changes Jul 4, 2023
Copy link
Member

@Xazin Xazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

lib/presentation/routes/app_routes.dart Outdated Show resolved Hide resolved
Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com>
@wizlif wizlif requested a review from Xazin July 4, 2023 18:30
@Xazin Xazin merged commit b2206de into CollActionteam:development Jul 4, 2023
7 checks passed
@wizlif wizlif deleted the fix/auth-routing branch July 7, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants