Local WOPI for debug builds #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rash419
changed the title
Rash419
force-pushed
the
local-wopi
branch
2 times, most recently
from
fd3dc15
to
7c45373
Compare
Rash419
changed the title
kendy
reviewed
Oct 25, 2021
There was a problem hiding this comment.
@Rash419 Thanks so much, this is great! To be able to integrate it, I'd like to ask you for few improvements from the code reading perspective - but nothing substantial :-)
One more thing that I didn't explicitly point to in the review; the C++ bits use a different formatting than the JS - the {'s and }'s are on new lines, please have a look at the other parts of the file reformat the code accordingly too.
Rash419
force-pushed
the
local-wopi
branch
2 times, most recently
from
1c06a96
to
7becb4a
Compare
…cal storage" (in debug builds) Signed-off-by: Rash419 <rashesh.padia@collabora.com> Change-Id: I9e21df4c5b611ca9989915180310f0991ed28725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rash419 rashesh.padia@collabora.com
Change-Id: Ia5cfcc4c345ad062ac3e93b0e4f9bc6321781b63
*github issue: https://github.com/CollaboraOnline/online/issues/110