Fix Chromebook text input focus issues #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes various of focus problems related to writing. We have a hack for mobile devices for hiding onscreen keyboard and to do that, we blur the TextInput. But it is not relevant for Chromebooks despite being a mobile app. Also fixes calc text input problem, now theres no need to double tap on a cell to write. Change-Id: I674a3d553e130c34211c04ad0ebcb6401b462412 Signed-off-by: mert <mert.tumer@collabora.com>
|
I guess Tor is a good person to sync with here =) |
|
Well, I can only say that it if helps for the problem at hand, good. One point about the commit message, though: Is this about the Android app, running on a Chromebook? (No idea if that even is possible.) Or using Online in a web browser on a Chromebook? (If the latter, mentioning "mobile app" in the commit message is misleading.) |
|
@tml1024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various of focus problems related to
writing. We have a hack for mobile devices for
hiding onscreen keyboard and to do that, we blur the
TextInput. But it is not relevant for Chromebooks despite
being a mobile app.
Also fixes calc text input problem, now theres no need to
double tap on a cell to write.
Change-Id: I674a3d553e130c34211c04ad0ebcb6401b462412
Signed-off-by: mert mert.tumer@collabora.com
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay