Add cli option to use settings from env variables

[Minion3665]

Change-Id: I75762ad620132037523fa82167a3ff17075c7027

• Target version: master

Summary

Currently in docker it is possible to do configuration through
environment variables, which
works using the start-collabora-online.sh start-collabora-online.pl
scripts. This PR lets COOLWSD listen to the same environment
variables directly

TODO

• ...

Checklist

• Code is properly formatted
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[timur-g]

Can you please explain how this will work?

[Minion3665]

@timur-g

Can you please explain how this will work?

Sure thing! The idea is to be able to replace the work done by the docker scripts (see https://github.com/CollaboraOnline/online/blob/master/docker/from-packages/scripts/start-collabora-online.sh) directly in wsd...

if test -n "${username}"; then
    perl -pi -e "s/<username (.*)>.*<\/username>/<username \1>${username}<\/username>/" /etc/coolwsd/coolwsd.xml
fi
if test -n "${password}"; then
    perl -pi -e "s/<password (.*)>.*<\/password>/<password \1>${password}<\/password>/" /etc/coolwsd/coolwsd.xml
fi
if test -n "${server_name}"; then
    perl -pi -e "s/<server_name (.*)>.*<\/server_name>/<server_name \1>${server_name}<\/server_name>/" /etc/coolwsd/coolwsd.xml
fi
if test -n "${dictionaries}"; then
    perl -pi -e "s/<allowed_languages (.*)>.*<\/allowed_languages>/<allowed_languages \1>${dictionaries:-de_DE en_GB en_US es_ES fr_FR it nl pt_BR pt_PT ru}<\/allowed_languages>/" /etc/coolwsd/coolwsd.xml
fi

This will let us remove those scripts entirely from docker, but we still want to keep the ability to add settings from environment variables because it makes configuring docker easier.

The idea here is to add an extra option (--use-env-vars) which will get COOLWSD to look at the same environment variables that the scripts did directly. Does that answer the question?

[timur-g]

Thanks, just one more. Will you update documentation?

[Minion3665]

@timur-g

Thanks, just one more. Will you update documentation?

thanks for the reminder! I've updated the manpage to add the new option now. I'd like to edit https://sdk.collaboraonline.com too but I don't know where the source to that is... do you?

[timur-g]

No, but I guess @thebearon knows.

[timar]

• remoteconfigurl is missing
• domain is missing (although it was deprecated by alias_groupX so probably we can skip it)

[timar]

• remoteconfigurl is missing
• domain is missing (although it was deprecated by alias_groupX so probably we can skip it)

I added remoteconfigurl.