Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid logging user content from spreadsheet cells #7177

Merged
merged 1 commit into from Oct 18, 2023

Conversation

caolanm
Copy link
Contributor

@caolanm caolanm commented Aug 28, 2023

when anonymization is enabled

Change-Id: I0aee79411b79745078f98581094d2ddb1638fad6

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@caolanm caolanm force-pushed the private/caolanm/avoid_logging_cell_content branch 2 times, most recently from 81293a7 to 4182a08 Compare August 30, 2023 20:01
@caolanm caolanm requested a review from Ashod August 31, 2023 08:09
Copy link
Contributor

@mmeeks mmeeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok - but I'd really prefer cropping the user data (except in trace mode) at or near the logging site of a specific problematic message - to avoid having lots of re-parsing code for messages we generated ourselves around the place :-)

@cosminh11
Copy link
Contributor

cosminh11 commented Sep 6, 2023

Should I open a fresh pull request for that (against master), or one that would go into this PR's branch?

@caolanm
Copy link
Contributor Author

caolanm commented Sep 6, 2023

making changes to this one is fine by me

@cosminh11
Copy link
Contributor

opened #7212

Signed-off-by: Cosmin Humeniuc <cosmin.humeniuc@1and1.ro>
Change-Id: I5bcf615521d13758b2b70a0c9466a3bbc1a0a918
@caolanm caolanm force-pushed the private/caolanm/avoid_logging_cell_content branch from f507d38 to 09686d9 Compare October 18, 2023 10:44
@caolanm caolanm removed the request for review from Ashod October 18, 2023 15:19
@caolanm caolanm merged commit 7dae294 into master Oct 18, 2023
12 checks passed
@caolanm caolanm deleted the private/caolanm/avoid_logging_cell_content branch October 18, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants