Writer: Set parent / child relationship in UI. #7200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gokaysatir
force-pushed
the
private/gokay/comment-replies
branch
2 times, most recently
from
b4cb748
to
3b36bb2
Compare
gokaysatir
force-pushed
the
private/gokay/comment-replies
branch
from
3b36bb2
to
399b8a9
Compare
eszkadev
reviewed
Sep 7, 2023
| return false; | ||
| lastChild = this.getIndexOf(this.sectionProperties.commentList[lastChild].sectionProperties.data.parent); | ||
| else if (comment.sectionProperties.children.length > 0) { |
There was a problem hiding this comment.
this is repeated code as few lines up, it would be good to move itinto separate method - code will be more readable
eszkadev
reviewed
Sep 7, 2023
| for (var i = 0; i < this.sectionProperties.commentList.length; i++) { | ||
| var comment = this.sectionProperties.commentList[i]; | ||
|
|
||
| if (comment.sectionProperties.data.parent === '0') { |
There was a problem hiding this comment.
this is repeated many times (check if parent is '0'), this has some special meaning I guess.
Would be good to create separate function for that which will name that check - will be easier to understand the code.
like isRootComment(comment) - or what does that mean...
eszkadev
approved these changes
Sep 7, 2023
gokaysatir
force-pushed
the
private/gokay/comment-replies
branch
from
399b8a9
to
8901139
Compare
Add new property to commentSection (children). Update commentListSection for Writer comments. Now the comments at the same position are separated. The parent / child relations are set by "parent" attribute. Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: I0a8ab060c133a51f4d09e71777cc6233b78a6efa
gokaysatir
force-pushed
the
private/gokay/comment-replies
branch
from
8901139
to
e56206a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I7476aa13ad5d77cbc888339fb0ccd2d485b8f274
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay