Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: don't try to set TCP_NODELAY on local Unix sockets. #7573

Merged
merged 1 commit into from Nov 1, 2023

Conversation

mmeeks
Copy link
Contributor

@mmeeks mmeeks commented Oct 30, 2023

Change-Id: Ic0f720554080a01b7a46abbffda023834016c0ea

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@mmeeks mmeeks requested a review from Ashod October 30, 2023 19:41
Copy link
Contributor

@Ashod Ashod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmeeks. Looks reasonable. (Though I wish we never had Unix sockets to begin with.)

@thebearon thebearon self-requested a review October 31, 2023 23:21
Copy link
Contributor

@thebearon thebearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android/iOS app builds fail with this in SocketPoll::insertNewFakeSocket(...):

  /home/collabora/jenkins/workspace/github_android_online_co-23.05/net/Socket.cpp:668:18: error: no matching function for call to 'create'
          socket = StreamSocket::create<StreamSocket>(std::string(), fd, true, websocketHandler);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/collabora/jenkins/workspace/github_android_online_co-23.05/net/Socket.hpp:1199:37: note: candidate function template not viable: requires at least 5 arguments, but 4 were provided
      static std::shared_ptr<TSocket> create(std::string hostname, const int fd, Type type, bool isClient,
                                      ^

Change-Id: Ic0f720554080a01b7a46abbffda023834016c0ea
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
@mmeeks mmeeks merged commit 08d9081 into master Nov 1, 2023
12 checks passed
@mmeeks mmeeks deleted the private/mmeeks/nodelay branch November 1, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants